cedricmagne commented 1 month ago

Description

Add LaunchDarkly as a Docusaurus plugin
Handling onChange event (update the feature flag will change the UI without any page reloading)
Update Github action to set LD_CLIENT_ID during the build.
Hardcoded LD_CLIENT_ID as we can't define different value based on branch environment. Safe to expose, see: https://docs.launchdarkly.com/sdk/client-side/javascript#initialize-the-client-and-evaluate-a-context

To test LaunchDarkly integration I added the value of the flag siwsrpLogin in the navigation bar. I'll remove this before merging

https://app.launchdarkly.com/projects/infura/flags/siwsrpLogin/targeting?env=test&selected-env=test

Update default value and check the UI

Preview

ACT-1379-add-launchdarkly

Checklist

Complete this checklist before merging your PR:

[ ] The proposed changes have been reviewed and approved by a member of the documentation team.

socket-security[bot] commented 1 month ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/design-tokens@1.12.0	None	`0`	113 kB	gudahtt
npm/@typescript-eslint/parser@7.13.1	Transitive: environment, filesystem	`+36`	3.44 MB	jameshenry
npm/dotenv@16.4.5	environment, filesystem	`0`	79.1 kB	motdotla
npm/eslint-plugin-react@7.34.3	filesystem Transitive: environment, eval	`+103`	5.97 MB	ljharb
npm/launchdarkly-js-client-sdk@3.3.0	None	`+5`	1.55 MB	launchdarkly
npm/prettier@3.3.2	environment, filesystem, unsafe	`0`	8.25 MB	prettier-bot

🚮 Removed packages: npm/@metamask/design-tokens@1.13.0, npm/@typescript-eslint/parser@7.12.0, npm/eslint-plugin-react@7.34.2, npm/prettier@3.3.1

View full report↗︎

socket-security[bot] commented 1 month ago

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

cedricmagne commented 1 month ago

Hi @adonesky1, In this PR we added LaunchDarkly and we need to add a new environment variable LD_CLIENT_ID. May I send you this env on slack to add it in Github secret? Thanks