MetaMask / metamask-docs

Developer documentation for MetaMask
https://docs.metamask.io
Apache License 2.0
661 stars 946 forks source link

Upgrade Docusaurus and ESLint #1335

Closed alexandratran closed 3 months ago

alexandratran commented 4 months ago

Description

Issue(s) fixed

Fixes #1122 Fixes #716

Preview

Checklist

Complete this checklist before merging your PR:

socket-security[bot] commented 4 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@docusaurus/core@3.4.0 Transitive: environment, eval, filesystem, network, shell, unsafe +1000 87.8 MB slorber
npm/@docusaurus/eslint-plugin@3.4.0 Transitive: environment, filesystem +42 3.64 MB
npm/@docusaurus/module-type-aliases@3.4.0 Transitive: environment, eval, filesystem, network, shell, unsafe +197 21 MB slorber
npm/@docusaurus/plugin-client-redirects@3.4.0 Transitive: environment, eval, filesystem, network, shell, unsafe +473 53.5 MB
npm/@docusaurus/plugin-content-docs@3.4.0 environment, filesystem Transitive: eval, network, shell, unsafe +548 56.9 MB slorber
npm/@docusaurus/theme-common@3.4.0 environment Transitive: eval, filesystem, network, shell, unsafe +559 58.8 MB slorber
npm/@docusaurus/theme-mermaid@3.4.0 Transitive: environment, eval, filesystem, network, shell, unsafe +564 103 MB
npm/@docusaurus/tsconfig@3.4.0 None 0 2.13 kB slorber
npm/@eslint/js@9.4.0 None 0 14.2 kB eslintbot
npm/@lavamoat/allow-scripts@3.0.4 environment Transitive: filesystem, network, shell, unsafe +124 7.69 MB boneskull
npm/@metamask/design-tokens@1.12.0 None 0 113 kB gudahtt
npm/@metamask/docusaurus-openrpc@0.4.1 Transitive: environment, eval, filesystem, network, shell, unsafe +865 119 MB metamaskbot
npm/eslint-plugin-markdown@5.0.0 Transitive: environment +13 869 kB eslintbot
npm/eslint-plugin-react@7.34.2 filesystem Transitive: environment, eval +105 6.02 MB ljharb
npm/globals@15.3.0 None 0 152 kB sindresorhus
npm/prettier@3.3.0 environment, filesystem, unsafe 0 8.25 MB prettier-bot
npm/typescript-eslint@7.12.0 Transitive: environment, filesystem +44 3.68 MB
npm/typescript@5.2.2 None 0 40.6 MB typescript-bot

🚮 Removed packages: npm/@docusaurus/core@3.3.2, npm/@docusaurus/eslint-plugin@3.3.2, npm/@docusaurus/module-type-aliases@3.3.2, npm/@docusaurus/plugin-client-redirects@3.3.2, npm/@docusaurus/plugin-content-docs@3.3.2, npm/@docusaurus/theme-common@3.3.2, npm/@docusaurus/theme-mermaid@3.3.2, npm/@lavamoat/allow-scripts@2.5.1, npm/@metamask/design-tokens@1.13.0, npm/@metamask/docusaurus-openrpc@0.4.0, npm/@tsconfig/docusaurus@1.0.7, npm/@typescript-eslint/eslint-plugin@5.62.0, npm/@typescript-eslint/parser@5.62.0, npm/eslint-plugin-react@7.34.1, npm/eslint-plugin-unused-imports@2.0.0, npm/prettier@3.2.5, npm/typescript@4.9.5

View full report↗︎

socket-security[bot] commented 4 months ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Shell access npm/foreground-child@3.1.1
Shell access npm/foreground-child@3.1.1
New author npm/abbrev@2.0.0
Network access npm/socks-proxy-agent@8.0.3
Network access npm/agent-base@7.1.1
Network access npm/agent-base@7.1.1
Network access npm/agent-base@7.1.1
Network access npm/@npmcli/agent@2.2.2
Network access npm/@npmcli/agent@2.2.2
Network access npm/@npmcli/agent@2.2.2
Network access npm/@npmcli/agent@2.2.2
Network access npm/@npmcli/agent@2.2.2
New author npm/validate-npm-package-name@5.0.1
New author npm/@metamask/open-rpc-docs-react@0.2.0
Shell access npm/update-browserslist-db@1.0.16
New author npm/micromatch@4.0.7
Unstable ownership npm/micromatch@4.0.7

View full report↗︎

Next steps

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/foreground-child@3.1.1
  • @SocketSecurity ignore npm/abbrev@2.0.0
  • @SocketSecurity ignore npm/socks-proxy-agent@8.0.3
  • @SocketSecurity ignore npm/agent-base@7.1.1
  • @SocketSecurity ignore npm/@npmcli/agent@2.2.2
  • @SocketSecurity ignore npm/validate-npm-package-name@5.0.1
  • @SocketSecurity ignore npm/@metamask/open-rpc-docs-react@0.2.0
  • @SocketSecurity ignore npm/update-browserslist-db@1.0.16
  • @SocketSecurity ignore npm/micromatch@4.0.7