search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.08k stars 4.94k forks source link

Crash recovery leads popup number to be incorrect #10022

Open wbt opened 3 years ago

wbt commented 3 years ago

Describe the bug After recovery from a crash, the number shown on the Metamask icon has an off-by-one error.

Steps to reproduce These are the steps I followed but I can't claim they're easy to follow/reproduce:

A dapp triggered a set of 18 transactions, which must be individually confirmed because #4050 is not implemented. After 17 successful confirmations, MetaMask crashed. The separate popup windows report as Not Responding to Windows (but can be closed with the X button in the upper right); clicking on the popup with its "1 [transaction pending]" indicator produced nothing. Trying to Inspect Popup produced nothing.
On loading a dapp page in a different tab, the dapp crashed, presumably in one of the lines where it tries to initialize MetaMask, and used its normal interface hang reporting. Switching to another tab, Metamask's crash completely crashed Chrome.

On restarting Chrome, the "1 [transaction pending]" indicator remained visible on the MetaMask icon. Clicking on the MetaMask icon produced a login dialogue as is typical after restarting the browser. After entering the password, the dialogue was dismissed and the [1] disappeared. However, the transaction remained pending. Guessing and clicking the MetaMask icon to get the popup, I could see the confirmation dialogue, and confirm the transaction.

Expected behavior The numeric indicator of pending transactions should still be present if there is a pending transaction, even after user login; user login should not count for this purpose as approving a pending transaction.

Gudahtt commented 3 years ago

This reproduction looks pretty challenging! We should at least audit the logic for this badge number though, even if we can't repro this. The badge number logic is fairly concise.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

wbt commented 1 year ago

If there hasn't been anything specific to fix this, it's probably still an issue.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

wbt commented 12 months ago

If there hasn't been anything specific to fix this, it's probably still an issue.

github-actions[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

wbt commented 8 months ago

If there hasn't been anything specific to fix this, it's probably still an issue.

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.