MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.05k stars 4.92k forks source link

Unable to install modules due to node version conflicts #10138

Closed alex-miller-0 closed 3 years ago

alex-miller-0 commented 3 years ago

Describe the bug I can't seem to install modules with yarn due to two different dependencies requiring conflicting versions of node to install.

Steps to reproduce (REQUIRED)

I am using the current tip of develop: 47fd9bf45d77572cc697ce1a48bfb9675b37e4fc

When using node 10.18.1:

[3/5] 🚚  Fetching packages...
error orbit-db-store@3.5.0: The engine "node" is incompatible with this module. Expected version ">=12.0.0". Got "10.18.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Switching to node 12.14.1:

[1/5] 🔍  Validating package.json...
error metamask-crx@0.0.0: The engine "node" is incompatible with this module. Expected version "^10.18.1". Got "12.14.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

I can remove the engine restriction in package.json and switch to "node": "^12.14.1", but trying to install with node 12 still fails due to a different dependency:

[3/5] 🚚  Fetching packages...
error sesify@4.2.2: The engine "node" is incompatible with this module. Expected version "^10.15.1". Got "12.14.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Expected behavior

yarn should successfully install node modules.

alex-miller-0 commented 3 years ago

Seems something was cached on my system. It is working now. Sorry about that.

Sentrycs commented 3 years ago

I am having exactly the same problem. I did run yarn cache clean, but no success. Any suggestions?

alex-miller-0 commented 3 years ago

@Sentrycs I'm pretty sure I had to re-clone the repo, unfortunately.

Sentrycs commented 3 years ago

@alex-miller-0 What OS did you use?

alex-miller-0 commented 3 years ago

Mac OS (Catalina)