MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.7k stars 4.79k forks source link

Snaps Installation UI #11682

Closed Gudahtt closed 2 years ago

Gudahtt commented 2 years ago

We should allow dapps to request permission to use snaps when requesting permissions or connecting. If the user doesn't have the snap installed yet, this should initiate the snap install process. We will need to download the snap manifest and present the user with enough information to decide whether or not to install the snap. This should include:

This UI should be incorporated into the connect flow, so that the dapp is completely ready to use after the connection process.

As a user, I want to be notified of the following snaps errors:

https://www.figma.com/file/nBKUQx0btfQiqVf30UA6KD/Flask-MVP?node-id=336%3A9134

Gudahtt commented 2 years ago

This is blocked by #11626

holantonela commented 2 years ago

After our permissions discussion, I consolidated the last version here, ready for review:

https://www.figma.com/file/nBKUQx0btfQiqVf30UA6KD/?node-id=336%3A6342

Converting the requirement's list in a to-do here too.

holantonela commented 2 years ago

The reason I'm being asked to install the snap (e.g. the dapp that asked permission to use the snap). is it ok to think about this requirement as a step in the connect flow where "the site wants to connect with snap" ? For a reference see flow "Add Snap - Site permissions"

holantonela commented 2 years ago

The place the snap was downloaded from is this a URL? How we want to show it?

Gudahtt commented 2 years ago

is it ok to think about this requirement as a step in the connect flow where "the site wants to connect with snap" ?

Yes - definitely. I think that would fulfill the requirement anyway. I guess we'll see if users are confused or not :sweat_smile:. We can spell it out for them if it becomes an issue.

is this a URL? How we want to show it?

See my comment on the other issue.

holantonela commented 2 years ago

Final UI here

https://www.figma.com/file/nBKUQx0btfQiqVf30UA6KD/Flask-MVP?node-id=336%3A6575