Add device model to account_type

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites

https://metamask.io

Other

12.05k stars 4.92k forks source link

Add device model to account_type #13936

Open AlexJupiter opened 2 years ago

AlexJupiter commented 2 years ago

https://github.com/MetaMask/metamask-extension/pull/13682 added hardware wallet brands to the account_type attribute, however we now need to distinguish the device model (e.g. Ledger Nano S or Ledger Nano X) and also split out the QR devices into their separate brands (e.g. Keystone or AirGap).

worldlyjohn commented 2 years ago

Adding a bit more color here to match our new standards

When property account_type == hardware then the following properties can be included:

account_hardware_type (string): ledger, trezor, lattice, qr_code (lowercase from DEVICE_NAMES in constants/hardware-wallets.js)
account_hardware_version (string): hardware_version_here (e.g. S 1.1.0, X 1.1.0)