search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.08k stars 4.93k forks source link

Improve current implementation of bundle size charts #15506

Open jpuri opened 2 years ago

jpuri commented 2 years ago

We have charts being generated for bundle side in background and UI.

  1. Currently we generate a JSON file with bundle size stats for each commit, this can cause performance issues as number of files grow. We need to check about the option of using single JSON file to store data.

  2. As number of commits increase we can possibly club the commits which have same bundle size.

  3. Create a stacked view for common + background bundle size and common + ui bundle size.

  4. Add initialisation time to bundle size chart, it will help us co-relate the 2.

cc @danjm , @kumavis , @kevinghim

jpuri commented 2 years ago

PR partially fixes this issue: https://github.com/MetaMask/metamask-extension/pull/15793

brad-decker commented 2 years ago

Adding contributor experience label to this as its aligned with our goals but this should not block MV3 team from progressing if it is necessary for MV3 timelines. @hilvmason