search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.69k stars 4.78k forks source link

MV3: Support dapp legacy provider #15988

Open digiwand opened 1 year ago

digiwand commented 1 year ago

Describe the bug

This support should piggyback off the support we have for dapp pages. It might already be supported with the dapp work found in the related epics.

Steps to reproduce

Error messages or log output

No response

Version

10.19.x

Build type

No response

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

seaona commented 1 year ago

I confirm that the providers function is not working at the moment (MV2 and MV3). I see the following errors:

https://user-images.githubusercontent.com/54408225/204846224-2f4c154b-106d-43e3-a89c-677c15a3e555.mp4

Repro Steps:

  1. Clone this repo https://github.com/seaona/test-extension
  2. Install dependencies cd extension npm i
  3. Build the extension npm run extension
  4. Import extension root folder into Chrome
  5. Unlock MM
  6. Open test extension
  7. Right click and open the console
  8. Click Connect to MetaMask
seaona commented 1 year ago

@digiwand I opened a separate ticket for the issue I commented above https://github.com/MetaMask/metamask-extension/issues/16797