search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.96k stars 4.89k forks source link

Investigation: examine if we can remove/replace/update ethereumjs-wallet in `@metamask/eth-hd-keyring` and `@metamask/eth-simple-keyring` #16513

Closed adonesky1 closed 1 year ago

adonesky1 commented 1 year ago

Investigation: examine if we can remove/replace/update ethereumjs-wallet in @metamask/eth-hd-keyring and @metamask/eth-simple-keyring smart-transactions-controller and @metamask/controllers @metamask/snap-controller and @metamask/metamask-extension (direct-dep)

Currently direct dep in the extension is v0.6.5 while the rest are 1.0.1 so at the very least lets de-dedupe it.

adonesky1 commented 1 year ago

will be partially addressed by https://github.com/MetaMask/eth-hd-keyring/pull/69

cryptodev-2s commented 1 year ago

should be partially addressed by KeyringController#171

adonesky1 commented 1 year ago

completed here: https://github.com/MetaMask/eth-hd-keyring/commit/caa0160bd07a60c6681a3b03130e0b546ce48c1c