search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.93k stars 4.88k forks source link

Investigate whether we can remove `eth-lattice-keyring > gridplus-sdk > eth-eip712-util-browser` #16541

Open adonesky1 opened 1 year ago

adonesky1 commented 1 year ago

size: 84kb

danjm commented 1 year ago

This might not be part of the latest versions of gridplus-sdk. @brad-decker to confirm

brad-decker commented 1 year ago

It is in fact being used. I was able to completely remove this package by patching in using @metamask/eth-sig-util instead of this package in gridplus-sdk. Technically this will increase gridplus-sdk dependency size. but it will reduce our bundle size because of the alignment between the dependencies. I did not test if this WORKS but its an option.

brad-decker commented 1 year ago

Alternatively gridplus or us could reach out to coinbase to produce a new build of the -browser version of eth-eip712-util OR have gridplus simply use eth-eip712-util as I dont' see why the -browser version was made in the first place.