MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.05k stars 4.92k forks source link

[Enhancement]: cross chain address book #16672

Open marsrobertson opened 1 year ago

marsrobertson commented 1 year ago

Describe the enhancement

address book

I'm aware I'm doxxing myself but my ENS names are on chain anyway, I'm not running darknet marketplace, I err on the side of adoption, simplicity, usability. Please don't hack me.

Steps to reproduce

  1. Paste address that is in the address book on Ethereum - Binance deposit address
  2. Change the chain
  3. Paste the same address on Fantom - not found

Cross chain address book would be nice

Error messages or log output

No response

Version

10.22.1

Build type

No response

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

I've tried to search for "address book" in open issues and didn't find, that's why opening a new issue.

web3-person commented 1 year ago

Cross chain addresses do not always match. (See wintermute OP token exploit)

marsrobertson commented 1 year ago

Cross chain addresses do not always match.

Exception rather than a rule.

99% they match.

Balance of usability and security is towards unified address book.

Are there any genuine use cases where the same 0x123...ABC address belongs to different people?

In case of $OP and Wintermute:

It doesn’t necessarily work across chains. “Having control over mainnet Safe doesn’t guarantee control on other EVM compatible chains (unlike ordinary wallets),” Wintermute explained in a message to the Optimism community on the Layer 2’s forum.

Source: https://thedefiant.io/optimism-20m-exploit

I still believe it is an exception, not a rule. Since then, has any action been taken on the Gnosis Safe side to avoid similar exploits in the future?