search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.03k stars 4.91k forks source link

Add ability to delete metametrics data #16709

Open danjm opened 1 year ago

danjm commented 1 year ago

In mobile users can delete there metametrics data by clicking a button. We should add this ability within the extension

Our metrics implementation is not identical. Research is required to determine exactly how we will do this on the extension side.

hilvmason commented 1 year ago

@coreyjanssen -- this issue requires copy updates; @brad-decker & @holantonela can assist with further context.

coreyjanssen commented 1 year ago

@brad-decker @holantonela what is materially different about this within extension vs desktop from the user's perspective? asking bc if there isn't much beyond things that happen on the backend, the mobile copy looks like it would work in this scenario too!

brad-decker commented 1 year ago

The difference is that users may have multiple installs of MetaMask (brave, chrome, firefox, etc) they also may uninstall and reinstall the extension and their userId would change. we should clarify the copy to make sure that it will only delete the data related to this install and will not delete data from any other installs OR metamask mobile @coreyjanssen

brad-decker commented 1 year ago

@danjm @hilvmason @kevinghim we have an issue here where the segment API requires an API key that would need to be included in our builds and could theoretically be used to either brute force delete OR other segment api end points (such as manipulating user list for accessing our workspace). I'm working with @worldlyjohn to get an idea of what the actual dangers are here but we may want to explore alternative options for implementation. https://consensys.slack.com/archives/GTQAGKY5V/p1669912934330049

coreyjanssen commented 1 year ago

Gotcha @brad-decker! Thoughts on this rewrite @kevinghim?

MetaMetrics data is anonymized usage and diagnostic data. This will delete historical MetaMetrics data associated with this install of your wallet, but won’t delete data from any other installs or the MetaMask mobile app. Your wallet and accounts will remain exactly as they are now after this data has been deleted. This process may take up to 60 days. View the Consensys Privacy Policy.

kevinghim commented 1 year ago

@coreyjanssen should this "but won’t delete data from any other installs or the MetaMask mobile app." be "but won’t delete data from any other installs or from the MetaMask mobile app." ?

coreyjanssen commented 1 year ago

Either is correct, just a matter of preference! Let's add it for the most specificity. :)

Updated:

MetaMetrics data is anonymized usage and diagnostic data. This will delete historical MetaMetrics data associated with this install of your wallet, but won’t delete data from any other installs or from the MetaMask mobile app. Your wallet and accounts will remain exactly as they are now after this data has been deleted. This process may take up to 60 days. View the Consensys Privacy Policy.

kevinghim commented 1 year ago

Currently blocked by API team.

gauthierpetetin commented 9 months ago

If I'm correct, this is not blocked by API team anymore. cc @hesterbruikman for visibility

gauthierpetetin commented 9 months ago

If I'm correct, this is not blocked by API team anymore. cc @hesterbruikman for visibility

hesterbruikman commented 9 months ago

Thanks for the ping @gauthierpetetin! You're right, we should be able to use the endpoint for data deletion on Segment already provided for Mobile