search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.03k stars 4.91k forks source link

Enhance how we fetch names for erc1155 contracts #17517

Open bschorchit opened 1 year ago

bschorchit commented 1 year ago

We should investigate and consider addressing these 2 situations where we currently fail to get a name for a NFT contract:

  1. When name is only set in ERC1155 tokenUri
  2. When contract uses a proxy (example here: https://etherscan.io/address/0x4bcb8a15af2c67e9a041eda4dd4a385dceffee39#code )
bschorchit commented 1 year ago

This might be happening for any ERC1155 NFT - see report here https://github.com/MetaMask/metamask-extension/issues/18133