search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.83k stars 4.83k forks source link

Support web3 1.0 beta #1806

Closed danfinlay closed 6 years ago

danfinlay commented 7 years ago

Web3 1.0 beta is now out and available for experimentation with.

This issue should represent a place to define what that support will mean for us, and then we can implement that plan.

http://web3js.readthedocs.io/en/1.0/web3.html

kumavis commented 7 years ago

part of the 1.0 is the acceptance that web3 is a good at being a library and not at being a standard -- so we should not inject web3 1.0

now we just need the ethereumProvider api finalized

cmditch commented 7 years ago
  1. Metamask uses Infura
  2. Web3 1.0 is deprecating HttpProvider for web3.eth.subscribe and other log/event related functions, and opting for Websockets instead.

I'm guessing Infura is coding up a solution for websockets? Or is Infura already supporting websockets?

I've been having trouble testing web3 1.0 event/log functions as TestRPC doesn't support websockets, Parity requires authentication, Infura doesn't seem to have support yet.

Curious what setup you guys/gals have been using? Thanks!

rstormsf commented 6 years ago

also web3.eth.accounts is not an array of accounts. web3.eth.accounts.wallet is what being used to load your current accounts.

cmditch commented 6 years ago

@rstormsf Metamask might not tie into the new web3 wallet functionality

I'm guessing they'll keep their implementation and still rely on web3.eth.getAccounts and web3.eth.defaultAccount

danfinlay commented 6 years ago

Closing as duplicate of #2350