MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.96k stars 4.89k forks source link

[Bug]: Cannot read properties of undefined (reading 'maxPriorityFeePerGas') #19091

Closed DemonRx closed 1 year ago

DemonRx commented 1 year ago

Describe the bug

Screenshot from 2023-05-10 19-44-15

Steps to reproduce

  1. Visit a sites such as uniswap or camelot.exchange or swapfish.fi swap pages
  2. connect the wallet
  3. select a coin to swap (that requires spending approval)
  4. click approve which opens metamask to set the spending cap
  5. click approve in metamask
  6. the error then appears instead of going to the confirmation/gas fee dialogue

Error messages or log output

Error messages is displayed in the attached screenshot to this bug report

Version

10.30.1

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

I downgraded metamask to version 10.29 and the error no longer occurs.

anaamolnar commented 1 year ago

Hello @DemonRx. Thank you for reporting! Does this occur only on Ethereum Mainnet, or is consistent across other chains as well? Could you please send us a screenshot of your browser console logs when this error occurs? To do that, please follow these steps:

Thank you!

snorkypie commented 1 year ago

I have this exact problem. Works fine in 10.29.0 but broken in 10.30.1. I've attached screenshot from the console.

Screenshot 2023-05-11 at 12 38 06
anaamolnar commented 1 year ago

@snorkypie Thank you! Do you remember what you were doing before this happened? Does this occur on Ethereum mainnet for you, or on a different custom chain?

snorkypie commented 1 year ago

@snorkypie Thank you! Do you remember what you were doing before this happened? Does this occur on Ethereum mainnet for you, or on a different custom chain?

This happens when clicking "Next" in Step 1 of approve (ERC20).

This is on Arbitrum. I don't have the ability to test this on Ethereum mainnet at the moment.

DemonRx commented 1 year ago

@anaamolnar This is occuring on multiple chains. I've tested on Binance smart chain, arbitrum and polygon.

I need to stay on version 10.29 for the moment as I have to be sure I can make some transactions today.

Afterwards, I can retest 10.30.1.

DemonRx commented 1 year ago

In regards to metamask on mobile I believe it's the same issue occuring there except you only see "internal json RPC error". The problem only occurs when approving token spending caps.

However it occurs intermittently.

Screenshot_20230507_091924_MetaMask

vANJKEEE commented 1 year ago

Hello! I have exactly the same problem. I didn't check other networks, but on after updating the extension from version 10.29 to 10.30 = this problem immediately appeared. When I try to set the approve limit, I get an error.

Chrome/Win10

Screenshot_22

sg4you commented 1 year ago

Same for me on 10.30.1, Chrome/Windows10, Eth mainnet, yesterday a layer2 with same error. Seems to be when trying to abrove token/nft allowances.

ShirmineWang commented 1 year ago

Same for me on 10.30.1, arbitrum, when approve token allowances. Is this one fixed?

ShirmineWang commented 1 year ago

any work through?

thuesdays commented 1 year ago

Same for me on 10.30.1, arbitrum, when approve token allowances. Is this one fixed?

Same issue with Arbitrum on token approval from https://stargate.finance/ version 10.30.1 Message: Cannot read properties of undefined (reading 'maxPriorityFeePerGas')

Code: TypeError

Stack: TypeError: Cannot read properties of undefined (reading 'maxPriorityFeePerGas') at _ (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-5.js:1:33041) at ha (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:60036) at Cu (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:104794) at Tl (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:90710) at gl (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:90635) at fl (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:87983) at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:46441 at n.unstable_runWithPriority (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:417870) at $o (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:46150) at Zo (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:46386) at Jo (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:46321) at ue (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:114836) at Pn (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:29796)

alpari163 commented 1 year ago

I have same problem I get this error on many wallets, only ARB chain and only when I try approve usdc spend, first it was on bebop xyz , i thought it was a bebop issue, but now I get this error when try approve spending on defillama (arb chain too)

Alistrago commented 1 year ago

The same problem on Arbitrum chain.

MetaMask encountered an error Try again by closing and reopening the popup, or contact support here. Error details Message: Cannot read properties of undefined (reading 'maxPriorityFeePerGas')

Code: TypeError

Stack: TypeError: Cannot read properties of undefined (reading 'maxPriorityFeePerGas') at _ (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-5.js:1:33041) at ha (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:60036) at Cu (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:104794) at Tl (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:90710) at gl (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:90635) at fl (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:87983) at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:46441 at n.unstable_runWithPriority (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:417870) at $o (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:46150) at Zo (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:46386) at Jo (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:46321) at ue (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:114836) at Pn (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/ui-3.js:1:29796)

Alistrago commented 1 year ago

I have just opened tread in Twitter. You can write there, tag Metamsk and Metamask support https://twitter.com/alistrago_crypt/status/1657429244220260354?s=46&t=tC9o1HiSoOdR40NuapxmLA

iamdimka1 commented 1 year ago

Hi guys, I also have this problem. Can you help me? The problem on Metamask version 10.30.1.

Alistrago commented 1 year ago

Download 10.29 version MM

Alistrago commented 1 year ago

Reply from MM support:

Hello there Thank you for reaching MetaMask Technical Support! 🦊

We have identified the "maxPriorityFeePerGas" bug and are currently working on a hotfix. We expect to release the fix shortly with a hotfix. Rest assured, we will keep you informed on any updates. We sincerely apologize for any inconvenience this issue or bug may have caused you.

Some users have reported being able to temporarily resolve/fix the issue by re-installing the app with their SRP.

iamdimka1 commented 1 year ago

Thanks!

Michal2034 commented 1 year ago

Reinstalling doesn't really helps I switched to OKX Wallet - its multichain - https://twitter.com/LewiczMichal/status/1658165326293483520?s=20

iamdimka1 commented 1 year ago

I updated Metamask to 10.30.2 and issue was resolved. Thanks metamask team for the quickly bug fix.

Starmand6 commented 1 year ago

I am currently getting this error on version 11.0.0. Same circumstances as others: happened when approving DAI and USDC token allowances on Arbitrum, using Brave browser.