MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.88k stars 4.85k forks source link

Replace deprecated Popover component with Modal from the component-library #19555

Open georgewrmarshall opened 1 year ago

georgewrmarshall commented 1 year ago

Description

Currently, the extension is using an outdated Popover component, which needs to be replaced with the new Modal component.

This is a massive undertaking by itself and creating a single PR would be too large. Smaller PRs can be submitted against this issue to ensure easier review and gradual improvements.

Technical Details

Acceptance Criteria

If the acceptance criteria is not met, PRs may be closed.

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with running the extension locally, have knowledge of React, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in the extension

ElRakabawi commented 1 year ago

Hey! Can I work on it?

georgewrmarshall commented 1 year ago

Hey @ElRakabawi, sure you can submit a PR against this issue ensuring that all the acceptance criteria is met! Thanks

panditdhamdhere commented 1 year ago

hey can contribute on it ?

georgewrmarshall commented 1 year ago

Hey @panditdhamdhere, you sure can! Just submit a PR against this issue ensuring that all the acceptance criteria are met! Thanks

shivam-puri commented 1 year ago

Hey! Can I help ??

georgewrmarshall commented 1 year ago

Hey @shivm29, Yes! Just submit a PR against this issue ensuring that all the acceptance criteria are met! Thanks