Open georgewrmarshall opened 1 year ago
hey @georgewrmarshall, just had one question about this, how do we plan on handling the tooltips?
Hey @dhruvv173, great question if it has tooltips then we could use the atomic component TextField
, Label
and HelpText
to reconstruct it?
Hey @dhruvv173, great question if it has tooltips then we could use the atomic component
TextField
,Label
andHelpText
to reconstruct it?
Something like combining example 2 and 3 from the image below(using Tooltip
component instead of Icon
) if im not wrong?
Something like combining example 2 and 3 from the image below(using
Tooltip
component instead ofIcon
) if im not wrong?
Yes, that would work!
Description
Currently, the extension is using an outdated
FormField
component, which needs to be replaced with the newFormTextField
component.This is a massive undertaking by itself and creating a single PR would be too large. Smaller PRs can be submitted against this issue to ensure easier review and gradual improvements.
Technical Details
ui/components/ui/form-field/form-field.js
) with FormTextField component (ui/components/component-library/form-text-field/form-text-field.js
)Acceptance Criteria
If the acceptance criteria is not met, PRs may be closed.
Difficulty: Intermediate
Good first issue for: External contributors who are familiar with running the extension locally, have knowledge of React, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in the extension