MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.88k stars 4.85k forks source link

Replace deprecated FormField component with FormTextField from the component-library #19737

Open georgewrmarshall opened 1 year ago

georgewrmarshall commented 1 year ago

Description

Currently, the extension is using an outdated FormField component, which needs to be replaced with the new FormTextField component.

This is a massive undertaking by itself and creating a single PR would be too large. Smaller PRs can be submitted against this issue to ensure easier review and gradual improvements.

Technical Details

Acceptance Criteria

If the acceptance criteria is not met, PRs may be closed.

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with running the extension locally, have knowledge of React, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in the extension

dhruvv173 commented 1 year ago

hey @georgewrmarshall, just had one question about this, how do we plan on handling the tooltips?

georgewrmarshall commented 1 year ago

Hey @dhruvv173, great question if it has tooltips then we could use the atomic component TextField, Label and HelpText to reconstruct it?

dhruvv173 commented 1 year ago

Hey @dhruvv173, great question if it has tooltips then we could use the atomic component TextField, Label and HelpText to reconstruct it?

Something like combining example 2 and 3 from the image below(using Tooltip component instead of Icon) if im not wrong? image

georgewrmarshall commented 1 year ago

Something like combining example 2 and 3 from the image below(using Tooltip component instead of Icon) if im not wrong? image

Yes, that would work!