search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.99k stars 4.91k forks source link

Fix flaky test Sign Typed Data Signature Request can initiate and confirm a Signature Request of Sign Typed Data #19823

Open DDDDDanica opened 1 year ago

DDDDDanica commented 1 year ago

Error message: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/101352/workflows/fb633881-146a-4682-8fe3-d865fc6bc5f0/jobs/3773393

pnarayanaswamy commented 3 weeks ago

This one flaked not due to a test issue but an issue on the CI, subsequent re-run of the test passed and the test has not flaked for over 13 days.

Error: Unable to obtain browser driver.
        For more information on how to install drivers see
        https://www.selenium.dev/documentation/webdriver/troubleshooting/errors/driver_location/. Error: Error executing command for /home/circleci/project/node_modules/selenium-webdriver/bin/linux/selenium-manager with --browser,firefox,--output,json,--browser-path,/opt/firefox/firefox: request or response body error: error reading a body from connection: stream error received: unexpected internal error encountered
  (Ran on CircleCI Node 3 of 24, Job test-e2e-firefox)
    at getPath (node_modules/selenium-webdriver/common/driverFinder.js:35:11)
    at thenableWebDriverProxy.createSession (node_modules/selenium-webdriver/firefox.js:594:45)
    at createDriver (node_modules/selenium-webdriver/index.js:152:33)
    at Builder.build (node_modules/selenium-webdriver/index.js:688:16)
    at FirefoxDriver.build (test/e2e/webdriver/firefox.js:97:28)
    at buildBrowserWebDriver (test/e2e/webdriver/index.js:41:34)
    at buildWebDriver (test/e2e/webdriver/index.js:20:13)
    at withFixtures (test/e2e/helpers.js:187:21)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Context.<anonymous> (test/e2e/tests/signature/signature-request.spec.js:68:7)
pnarayanaswamy commented 3 weeks ago

The tests however needed a small improvement that resulted in better execution times and are addressed in the PR https://github.com/MetaMask/metamask-extension/pull/27532