MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.03k stars 4.91k forks source link

Replace deprecated CheckBox component with Checkbox from the component-library #20163

Open georgewrmarshall opened 1 year ago

georgewrmarshall commented 1 year ago

Description

Currently, the extension is using an outdated CheckBox component, which needs to be replaced with the new Checkbox component.

This is a massive undertaking by itself and creating a single PR would be too large. Smaller PRs can be submitted against this issue to ensure easier review and gradual improvements.

Technical Details

Acceptance Criteria

If the acceptance criteria is not met, PRs may be closed.

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with running the extension locally, have knowledge of React, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in the extension

PrgrmrHarshShukla commented 1 year ago

Hey @georgewrmarshall , There is an issue I am facing while replacing the CheckBox component with Checkbox from the component-library. There is no visual regression upfront, but the checkmark and background do not appear and disappear on clicking the checkbox.

Please help. To keep things separate I opened a PR #20335 on the issue.

Screenshot 2023-08-01 154430

PRIZZA21 commented 1 year ago

hello I want to know if this issue is still open, can I work on it

PrgrmrHarshShukla commented 1 year ago

Yes, it is still open. Make sure to follow the rules while creating a PR for the same. 👍