Replace deprecated SiteOrigin component with TagUrl from the component-library

georgewrmarshall commented 1 year ago

Description

Currently, the extension is using an outdated SiteOrigin component, which needs to be replaced with the new TagUrl component.

This is a massive undertaking by itself and creating a single PR would be too large. Smaller PRs can be submitted against this issue to ensure easier review and gradual improvements.

Technical Details

Replace instances of SiteOrigin component (ui/components/ui/site-origin/site-origin.js) with TagUrl component (ui/components/component-library/tag-url/tag-url.js)
Component APIs are slightly different so ensure all props have been migrated appropriately

Acceptance Criteria

Instances of SiteOrigin component are completely replaced with the new TagUrl component
The component APIs are updated to reflect the changes in the new `SiteOrigin`` component and there is no functional changes or visual regression
Each Pull Request (PR) should include no more than 3 files
The code changes should pass Jest tests, linting, and Storybook without any errors.
The PR must include before and after screenshots of the UI to ensure there are no visual regressions.

If the acceptance criteria is not met, PRs may be closed.

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with running the extension locally, have knowledge of React, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in the extension

strawhatrag commented 1 year ago

Hi, @georgewrmarshall can I work on this ?

georgewrmarshall commented 1 year ago

Hi @strawhatrag, thanks for your interest in contributing to MetaMask. You certainly can contribute to this task! As this issue represents multiple PRs that many engineers could contribute to, it will not be assigned to any one contributor but rather represent the work of many. Please ensure that your PR meets all the acceptance criteria. I look forward to your PR

abdelrahmansheta16 commented 11 months ago

Hello @georgewrmarshall, how can I add labels to my PR, as this is my first time contributing to an issue?

georgewrmarshall commented 11 months ago

Hey @abdelrahmansheta16, I don't think external contributors have permissions to do so. If you tag me in the PR I can add the appropriate labels. Thanks!

mkos11 commented 8 months ago

@georgewrmarshall Hey I'm working issues from the same grouping as you are and I just managed to setup local for the first time. Can i work on this issue

georgewrmarshall commented 8 months ago

Hey @mkos11, apologies for the late reply. Feel free to open a PR and make sure it meets all the acceptance criteria listed in the issue. Thanks!

strawhatrag commented 4 months ago

@georgewrmarshall Replaced deprecated SiteOrigin in confirm-add-suggested-nft

georgewrmarshall commented 4 months ago

Thanks @strawhatrag! @garrettbear will review your PR

AMANn5153 commented 1 month ago

Hi, I would like to work on this issue. Is it still available?

AMANn5153 commented 4 weeks ago

added a new PR

MetaMask / metamask-extension