search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.87k stars 4.85k forks source link

[Bug]: Incorrect selected Network displayed on Approve screen #21694

Open seaona opened 10 months ago

seaona commented 10 months ago

Describe the bug

Problem: whenever I have a custom network with the same chain ID as one of the pre-default ones (i.e. Mainnet), if I trigger an Approve transaction from a Dapp, I can see how the displayed network on the Confirmation screen is the pre-defualt one, instead of the custom one that I have selected. Affected screens:

Expected behavior

We should display the custom selected network name

Screenshots/Recordings

See on top, the selected network is the custom network main tend but in the Confirmation screen is displayed Ethereum Mainnet

Screenshot from 2023-11-06 09-51-24

https://github.com/MetaMask/metamask-extension/assets/54408225/159cfcf2-6419-4f5e-bf8c-3ad459fc8128

Steps to reproduce

  1. Add a custom Mainnet network, with a custom name i.e. create a mainnet in Tenderly https://dashboard.tenderly.co/
  2. Select the custom network
  3. Go to this contract https://etherscan.io/token/0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48#writeProxyContract
  4. Connect MMM
  5. Click Approve
  6. Add any address and amount and confirm
  7. See Confirmation screen displays Ethereum Mainnet instead of your custom network

Error messages or log output

No response

Version

11.4.0 prod, possibly earlier too

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

seaona commented 6 months ago

we don't want this to be closed

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

github-actions[bot] commented 4 days ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.