search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.66k stars 4.78k forks source link

[Bug]: Editing gas fees in advanced settings is faulty, the zero value cannot be deleted #21724

Open benjisclowder opened 8 months ago

benjisclowder commented 8 months ago

Describe the bug

When you try to edit the gas fees, the zero is impossible to delete and every value you type will go after the zero. You need to place the value behind the zero and then delete the zero to make it work.

Expected behavior

The zero should be removable/replaced by other values

Screenshots/Recordings

https://github.com/MetaMask/metamask-extension/assets/120041701/82a7aeea-dbe5-4351-bbf9-6d79c8a69227

Steps to reproduce

  1. Log into MetaMask
  2. Fill in your password
  3. Switch over to a test network (e.g.: Sepolia)
  4. Head over to the test dapp: https://metamask.github.io/test-dapp/ and connect the MM account
  5. Proceed to send eip-1559 transaction
  6. Go to site suggested --> Advanced --> Attempt to change the gas fees and notice the zero is non-removable and every other value is added. after the zero

This is also a problem in the regular send flow with edited gas fees.

Error messages or log output

No response

Version

11.5.0

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

danjm commented 8 months ago

I found that this same behaviour exists on earlier versions as well, including v11.4.0 and v11.1.0

So I am going to remove the 11.5.0 related labels

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.