search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.96k stars 4.89k forks source link

[Sentry] Error: Ledger: Account 0x** does not belong to the connected device #22593

Open sentry-io[bot] opened 8 months ago

sentry-io[bot] commented 8 months ago

Sentry Issue: METAMASK-X84Y

Error: Ledger: Account 0x** does not belong to the connected device
  at LedgerKeyring.unlockAccountByAddress (node_modules/@metamask/eth-ledger-bridge-keyring/dist/ledger-keyring.js:322:1)
  at _LedgerKeyring_signTransaction (node_modules/@metamask/eth-ledger-bridge-keyring/dist/ledger-keyring.js:406:1)
  at KeyringController.signTransaction (node_modules/@metamask/eth-keyring-controller/dist/KeyringController.js:334:1)
gauthierpetetin commented 8 months ago

Hi @AlexJupiter , we've categorised this as a sev2 as we made the assumption user just connected a wrong ledger but it might also be a sev1 if the feature is broken => To be further investigated.

Akaryatrh commented 8 months ago

@AlexJupiter Following my investigations, potentially the user changed his ledger seed phrase after importing account on MM and then account could not match anymore. I don't think there's any way to fix that on our side.

gauthierpetetin commented 8 months ago

Hi @Akaryatrh , does it mean this is an expected scenario? If so, maybe the next step can be to handle the error properly, because it is currently unhandled.

AlexJupiter commented 8 months ago

@Akaryatrh your conclusion seems to make sense to me. In answer to @gauthierpetetin 's question, this is the expected scenario, but we should ideally present a this error in the UI to the user, although this is a lower priority for now (especially given the infrequent Sentry errors).

gauthierpetetin commented 8 months ago

Sounds good, I'll turn this into a sev3 then. Thanks for the investigation.

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

sentry-io[bot] commented 3 months ago

Sentry Issue: METAMASK-X9YM

github-actions[bot] commented 15 hours ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.