search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.7k stars 4.79k forks source link

[Bug]: PPOM - UI Warning for Signatures is cut when unfolding details which contain a long string (i.e. address) #22792

Open seaona opened 5 months ago

seaona commented 5 months ago

Describe the bug

Problem: whenever I trigger a malicious signature, I see that the warning is cut if I unfold it and it contains a long string (i.e. address)

Expected behavior

Wrap the content?

Screenshots/Recordings

Screenshot from 2024-02-02 11-44-45

Steps to reproduce

  1. Enable Blockaid
  2. Select Mainnet
  3. Go to the test dapp
  4. Trigger the Permit Signature
  5. Click See details
  6. See warning is cut

https://github.com/MetaMask/metamask-extension/assets/54408225/db0dba00-d57e-4b2a-8728-12805c6da7a3

Error messages or log output

No response

Version

11.7.5 and might be earlier (issue is in prod)

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

jpuri commented 3 weeks ago

This issue is already fixed in new designs, we need to fix it in old ones:

Screenshot 2024-06-25 at 5 31 42 PM Screenshot 2024-06-25 at 5 30 33 PM