MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.57k stars 4.73k forks source link

Create new inline contract-details field for easier verification #22962

Closed iainnash closed 2 weeks ago

iainnash commented 3 months ago

Description

Verifying signatures sources is quite important and moving the verification to a modal removes the context of what the verifying address is doing. Moving it inline and potentially linking in information from the associated NFT or ERC-20 contracts can better alert users to what they are doing and allow for super users to have better context when parsing signature transactions.

A signature associated with a low market cap coin while there is another with a high market cap coin can be confusing and a huge difference.

Related issues

Fixes:

Manual testing steps

  1. Attempt to sign a typed message
  2. See the verifying address inline rather than in a modal
  3. Allows for 1-click verification and (in the future) better display if you are signing against a ERC 20 / 721 token.

Screenshots/Recordings

Before

Screenshot 2024-02-14 at 5 00 22 PM

After

Screenshot 2024-02-14 at 4 28 28 PM

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 3 months ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

iainnash commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

github-actions[bot] commented 4 weeks ago

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

github-actions[bot] commented 2 weeks ago

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.