search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.7k stars 4.79k forks source link

[Bug]: Metamask does not import proxy token contracts #23034

Open Super-Genius opened 5 months ago

Super-Genius commented 5 months ago

Describe the bug

Some contracts implement ERC20 and ERC1155 Hybrid with EIP2535 diamond protocol. In that case, MetaMask should allow importing the ERC20 token.

https://polygonscan.com/token/0x127e47aba094a9a87d084a3a93732909ff031419

Metamask is the only Wallet that fails to import this hybrid token correctly.

Re-opening with a new issue, as it was closed. previously closed issue https://github.com/MetaMask/metamask-extension/issues/20522

Expected behavior

Metamask should allow the ERC-20 token to be imported. There is no reason to block a hybrid contract that supports both ERC-20 and ERC-1155 contract

Screenshots/Recordings

Screen Shot 2024-02-17 at 1 53 14 PM

Steps to reproduce

1, Add polygon network

  1. import token 0x127e47aba094a9a87d084a3a93732909ff031419 (GNUS)
  1. Use Ethereum network
  2. import token 0x251FAe8f687545BDD462Ba4FCDd7581051740463 (WATER)

Error messages or log output

Metamask shows an error. This token is an NFT. Add on the Import NFT page.

Version

11.7.5

Build type

None

Browser

Chrome, Firefox, Microsoft Edge, Brave

Operating system

Windows, MacOS, Linux

Hardware wallet

Ledger, Trezor, Keystone, GridPlus Lattice1, AirGap Vault, imToken

Additional context

None

Severity

Severe - Blocks user from seeing their tokens in the wallet and sending via MetaMask, as it doesn't support ERC-1155 transfers yet. All other wallets support this.

Bullcoiner commented 5 months ago

Hi There! Thank you for reporting this, it has been assigned to the appropriate team to be looked at.

Super-Genius commented 4 months ago

Any update on this? The last one went stale, so I'm going to keep adding comments so it won't automatically close.

Super-Genius commented 4 months ago

Once again, I'm adding a comment so this doesn't fall through the cracks; considering we filed this bug six months ago, it went stale and closed, and now many users are complaining.

We're redirecting them to BitGet extension, Mobile TrustWallet, etc. It works in your Mobile Metamask wallet, so I'm not sure why the extension is the only one that is is broken like this.

Super-Genius commented 3 months ago

Bump, so it doesn't get stale. Is there any update on the timeframe to fix this?

Super-Genius commented 3 months ago

@Bullcoiner Willing to pay a bounty to fix this.

danfodorean commented 3 months ago

@Bullcoiner also having this issue and it's annoying as hell

Super-Genius commented 3 months ago

@davidmurdoch, anyone? Willing to pay for it.

jfayad commented 3 months ago

Any update on this one ? I'm facing the same issue on the extension and would happily see it fixed.

Super-Genius commented 2 months ago

More than 3 months to fix this bug? Now Metamask incorrectly tags https://www.gnus.ai as a phishing website?

Are you trying to take down my project on purpose?

danfodorean commented 1 month ago

Bump of interest :)