MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.04k stars 4.92k forks source link

[Bug]: About the Extension manifest v3 build command #23283

Closed pemaju closed 2 months ago

pemaju commented 8 months ago

Describe the bug

Hi Team,

Now we have integrated your github code.

It’s working fine, while running “yarn dist” for manifest v2. But this not possible to publish in chrome store as you know.

So we build to manifest v3 by running “yarn dist:mv3”. But in this case when initially the extension was working good. But one time close a browser, again open it. its loading issue occurs

Screenshot from 2024-03-01 19-33-42

Kindly guide me. If anything missing my end

Thanks in advance

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

While close the browser, and open it again, See this issue

Screenshot from 2024-03-01 19-33-42

Error messages or log output

No response

Version

11.9.5

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

anaamolnar commented 7 months ago

Hello, @pemaju. Thanks for reporting this! I am really sorry I missed this. Please attempt this in the latest version and let us know if it still occurs. Thanks!

pemaju commented 6 months ago

we have fixed this issue. In app-init file we have changed the eventlistener from chrome.runtime.onMessage to chrome.runtime.onConnect.

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

github-actions[bot] commented 2 months ago

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.