MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.88k stars 4.85k forks source link

Confirmations redesign - add e2e for re-designed signature request message pages #23552

Open jpuri opened 6 months ago

jpuri commented 6 months ago

Create e2e tests to support the new confirmation/signature redesign

seaona commented 5 months ago

Test Scenarios

Manual Test Scenarios

digiwand commented 5 months ago

Hey team! Please add your planning poker estimate with Zenhub @cryptotavares @pedronfigueiredo

seaona commented 5 months ago

(Needs more input) Selected account not the current one warning is displayed when a different account than the connected one is selected

Adding explanation to this point, so it's clearer: it refers to the case when there is a miss-match between the account that's connected to the dapp and the currently selected account (not connected). We display the following warning in the current design and we should support something similar in the re-design:

Screenshot from 2024-04-11 18-03-45

cryptotavares commented 5 months ago

@seaona I see that behaviour on transactions but not on signatures 🧐

bschorchit commented 5 months ago

I think we used to have that for signatures, but we lost it when we updated the header for signatures. We can consider re-introducing it again once we have the alert system.