MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.85k stars 4.84k forks source link

[Bug]: What's new modal mark as seen not effective #23579

Open hesterbruikman opened 6 months ago

hesterbruikman commented 6 months ago

Describe the bug

What's new modal stops appearing when container is marked as seen. The container is marked as seen when you scroll enough for the container to have been 100% visible on the popup. Closing the modal does not stop modal from appearing again.

Expected behavior

What's new modal no longer appears after container has been 80% visible.

Screenshots/Recordings

No response

Steps to reproduce

  1. Open Extension
  2. Close modal
  3. Navigate to other tab
  4. Re-open Extension

Error messages or log output

No response

Version

11.12.2

Build type

Other (please specify exactly where you obtained this build in "Additional Context" section)

Browser

Brave

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

hesterbruikman commented 5 months ago

@darkwing could you get input from the team to refine and estimate this ticket please? It's expected behavior, but leading to the what's new modal to continuously popup. Obtrusive, undesirable, highly visible to all users. Depending on effort we can see to prioritise it.

hesterbruikman commented 5 months ago

To be addressed by #2271

hesterbruikman commented 5 months ago

To be addressed by #2271

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.