[Confirmations] Redesign - Signature Screens

[seaona]

What is this about?

1. Favicon has been removed

Favicon is not displayed. Should we consider displaying it or is it intentionally removed from the new re-design screens? See left side re-design, right side current production cc @bschorchit @SayaGT

2. Link to Etherscan has been removed

There is no link to Etherscan anymore for the verifying contract. See left side re-design, right side current production

Issue here https://github.com/MetaMask/MetaMask-planning/issues/2289

3. Signatures Navigation problems when mixing with Transactions

https://github.com/MetaMask/metamask-extension/issues/23692

4. Reverse String not properly Handled

https://github.com/MetaMask/metamask-extension/issues/23691

5. Blockaid styling in settings should be updated and warnings not displayed

https://github.com/MetaMask/metamask-extension/issues/23684 :red_circle: Important note: this also happens with develop builds without re-design enabled, meaning this would land in the next RC if not fixed

Furthermore, we don't see Blockaid warnings in Signatures (I think that's expected since notification task is pending?) cc @bschorchit

6. Account Balance displays incorrect currency

https://github.com/MetaMask/metamask-extension/issues/23690

7. Network Name not correct

https://github.com/MetaMask/metamask-extension/issues/23686

8. Sign Typed Data not using Re-design components

https://github.com/MetaMask/metamask-extension/issues/23688

9. Not able to Sign with a Hardware Wallet and HW warning missing

https://github.com/MetaMask/metamask-extension/issues/23687 There is also the warning missing, should this be fixed with the Notifications work? cc @bschorchit

10. Malformed Signatures broken

All the issues we currently have in prod, are also reproduceable with the new re-design screens. Do we aim to tackle those with the re-design or is this out of scope? cc @bschorchit @cryptotavares

• [Bug]: Signatures - Verify 3rd party details disappears if an empty domain is passed on a Typed Signature 3 & 4
• [Bug]: Signatures - MetaMask breaks with the error Invalid primary type definition
• [Bug]: Signatures - MetaMask breaks with error msg.map is not a function when passing an invalid type
• [Bug]: Signatures - Passing extra data not typed is added in the signature but not visible on the UI
• [Bug]: Signatures - MetaMask breaks with TypeError: text.slice is not a function when passing invalid verifyingContract

11. Signature message is not correct

https://github.com/MetaMask/metamask-extension/issues/23689

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

• [ ] Engineering (needed in most cases)
• [ ] Design
• [ ] Product
• [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
• [ ] Security
• [ ] Legal
• [ ] Marketing
• [ ] Management (please specify)
• [ ] Other (please specify)

References

No response

[bschorchit]

2. Link to Etherscan has been removed There is no link to Etherscan anymore for the verifying contract. Is this intentional? See left side re-design, right side current production

I've created an issue for this here: https://github.com/MetaMask/MetaMask-planning/issues/2289

[bschorchit]

5. Blockaid not present in settings and warnings not displayed https://github.com/MetaMask/metamask-extension/issues/23684 🔴 Important note: this also happens with develop builds without re-design enabled, meaning this would land in the next RC if not fixed

I do see it in settings and commented on the issue.

Furthermore, we don't see Blockaid warnings in Signatures (I think that's expected since notification task is pending?)

Yes, this task is still pending so we don't expect to see it yet on the redesigned screens.

[bschorchit]

9. Not able to Sign with a Hardware Wallet and HW warning missing https://github.com/MetaMask/metamask-extension/issues/23687 There is also the warning missing, should this be fixed with the Notifications work?

The work for this is still pending here: https://github.com/MetaMask/metamask-extension/issues/22743

[bschorchit]

10. Malformed Signatures broken All the issues we currently have in prod, are also reproduceable with the new re-design screens. Do we aim to tackle those with the re-design or is this out of scope? cc @bschorchit @cryptotavares

https://github.com/MetaMask/metamask-extension/issues/21011 https://github.com/MetaMask/metamask-extension/issues/22899 https://github.com/MetaMask/metamask-extension/issues/22525 https://github.com/MetaMask/metamask-extension/issues/22900 https://github.com/MetaMask/metamask-extension/issues/22901

I think we do want to leverage this opportunity to tackle these now.

[SayaGT]

1. Favicon has been removed Favicon is not displayed. Should we consider displaying it or is it intentionally removed from the new re-design screens? See left side re-design, right side current production

Yes its an intentional design for the new redesigned confirmations :)