search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.7k stars 4.79k forks source link

[Bug]: PPOM - Metrics event sets `loading` to the `security_alert_reason` for benign transactions #24157

Open seaona opened 2 months ago

seaona commented 2 months ago

Describe the bug

Whenever we are accepting or rejecting benign transactions, we can see how on the metrics event, the security_alert_reason is set to loading

Expected behavior

No response

Screenshots/Recordings

Screenshot from 2024-04-22 10-58-18

Steps to reproduce

  1. Go to the test dapp
  2. Trigger a benign tx
  3. Accept/reject
  4. Check metrics event (background network request or segment)
  5. See the security_alert_reason is set to loading

Error messages or log output

No response

Version

11.15.0 might be earlier too

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

jpuri commented 3 weeks ago

I still see this issue in latest code:

Screenshot 2024-06-25 at 6 08 08 PM