search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.01k stars 4.91k forks source link

[Bug]: Smart Transactions - Not seeing the `Submitting your transaction` screen for tx signed using a hardware wallet #24160

Open seaona opened 6 months ago

seaona commented 6 months ago

Describe the bug

Whenever I am using a hardware wallet, if I enable the Smart Transactions and I perform a transaction I land into the Home screen and I don't see the Submitting your transaction intermediate screen

Expected behavior

Not sure, but possibly we should display the Submitting your transaction screen, once we approve the tx in the device?

Screenshots/Recordings

https://github.com/MetaMask/metamask-extension/assets/54408225/ef6423ea-ef02-4589-91f3-e104ea125ace

This shows for regular accounts but not for hardware wallets:

Screenshot from 2024-04-22 11-46-46

Steps to reproduce

  1. Enable smart transactions
  2. Import a hardware wallet account (ie ledger, QR code acct etc)
  3. Start a tx
  4. Confirm it
  5. Confirm it with the device
  6. See no Submitting your transaction screen appears in this flow

Error messages or log output

No response

Version

11.15.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

github-actions[bot] commented 1 week ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.