search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.84k stars 4.84k forks source link

[Bug]: ENS name is not being presented in account list #24184

Open plasmacorral opened 4 months ago

plasmacorral commented 4 months ago

Describe the bug

Testing with v11.14.1 with Chrome 117.0.5938.92 in Mac Sonoma 14.3.1.

I was unsure if it was an issue with an older ERC721 ENS name, so I registered a fresh ERC1155 today and refreshed the extension and the HD account name remains Account 2. Also not working as I expect on both Ledger and QR hardware wallets.

I went back to v11.10.1 and can also observe the same behavior, so maybe this has been broken for awhile but I see no gh issue for this.

Expected behavior

I am expecting that an ENS name replaces the account name, when the public address reverse resolves to an ENS name.

Screenshots/Recordings

Recording of new ENS reservation of reserving a new ENS name on mainnet

Steps to reproduce

If you already have the address in test that reverse resolves to an ENS name:

  1. Have an ENS name on the account
  2. Go to Settings>Privacy & security
  3. Scroll down
  4. have the default setting of ON for Show ENS domains in address bar
  5. Tap the toggle to turn ON `Autodetect NFTs'
  6. Note that Display NFT media will also turn ON
  7. Check account list and note that ENS name is not showing
  8. Tap to open NFTs tab and note that ENS name should be present (if owned)
  9. Reload extension at chrome://extensions/
  10. Open extension
  11. Authenticate
  12. Note that ENS name still does not show in account list even when NFT is present

Or Register a new name (as recorded):

  1. Have an account with mainnet Eth
  2. Go to Settings>Privacy & security
  3. Scroll down
  4. have the default setting of ON for Show ENS domains in address bar
  5. Tap the toggle to turn ON Display NFT media
  6. Tap the toggle to turn ON `Autodetect NFTs'
  7. visit app.ens.domains and find a name
  8. Connect dapp to wallet and confirm
  9. Initiate timer transaction and sign
  10. wait 60 seconds
  11. Initiate reservation
  12. sign and broadcast
  13. Reload extension
  14. Open extension
  15. Authenticate
  16. Tap to open NFTs tab and note that ENS name should be present
  17. Note that ENS name still does not show in account list even when NFT is present

Error messages or log output

No response

Version

11.10.1

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

Ledger, Keystone

Additional context

Impacting HD as well as Hardware accounts

Severity

No response

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.