MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.52k stars 4.7k forks source link

ci: fix `Validate Conventional Commit Title` action #24356

Closed davidmurdoch closed 2 weeks ago

davidmurdoch commented 2 weeks ago

The Validate Conventional Commit Title action was only running when the PR was opened (and if the title or base are edited, or the PR was closed then re-opened). It was not when the branch had a new commit added; in that case, the previous run's status would just be completely ignored by GitHub.

Adding "synchronize" fixes it (as the installation instructions specify: https://github.com/amannn/action-semantic-pull-request?tab=readme-ov-file#installation)

note: we probably don't need "reopened", but I don't know why that was added in the first place so I'm not removing it.

I tested this here: https://github.com/MetaMask/metamask-extension/pull/24355/commits

Check out the statuses for each commit (hover over the red X). The action ran on the first commit, as expected, and it did not ran on the next two, but the last commit added synchronize (just like in this PR), and it ran again.

github-actions[bot] commented 2 weeks ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.37%. Comparing base (4a1853c) to head (72ce899).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #24356 +/- ## ======================================== Coverage 67.37% 67.37% ======================================== Files 1278 1278 Lines 49881 49881 Branches 12944 12944 ======================================== Hits 33605 33605 Misses 16276 16276 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

metamaskbot commented 2 weeks ago
Builds ready [72ce899]
Page Load Metrics (289 ± 342 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5513370209
domContentLoaded8151021
load452518289712342
domInteractive8151021
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)