Closed davidmurdoch closed 2 weeks ago
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.37%. Comparing base (
4a1853c
) to head (72ce899
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 55 | 133 | 70 | 20 | 9 |
domContentLoaded | 8 | 15 | 10 | 2 | 1 | ||
load | 45 | 2518 | 289 | 712 | 342 | ||
domInteractive | 8 | 15 | 10 | 2 | 1 |
The
Validate Conventional Commit Title
action was only running when the PR was opened (and if the title or base are edited, or the PR was closed then re-opened). It was not when the branch had a new commit added; in that case, the previous run's status would just be completely ignored by GitHub.Adding "synchronize" fixes it (as the installation instructions specify: https://github.com/amannn/action-semantic-pull-request?tab=readme-ov-file#installation)
note: we probably don't need "reopened", but I don't know why that was added in the first place so I'm not removing it.
I tested this here: https://github.com/MetaMask/metamask-extension/pull/24355/commits
Check out the statuses for each commit (hover over the red X). The action ran on the first commit, as expected, and it did not ran on the next two, but the last commit added
synchronize
(just like in this PR), and it ran again.