chore: bump assets controllers to latest

[sahar-fehri]

Description

Bumps assets-controllers to latest.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• [ ] I’ve followed MetaMask Coding Standards.
• [ ] I've completed the PR template to the best of my ability
• [ ] I’ve included tests if applicable
• [ ] I’ve documented my code using JSDoc format if applicable
• [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security[bot]]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/assets-controllers@29.0.0	Transitive: environment	+15	5.9 MB	metamaskbot
npm/@metamask/preferences-controller@11.0.0	None	+5	1.25 MB	metamaskbot
npm/@types/ms@0.7.34	None	0	3.2 kB	types
npm/cockatiel@3.1.3	None	0	409 kB	connor.peet
npm/jsonschema@1.4.1	None	0	81.8 kB	acubed

🚮 Removed packages: npm/@metamask/assets-controllers@26.0.0, npm/@metamask/polling-controller@5.0.1

View full report↗︎

[sahar-fehri]

@metamaskbot update-policies

[metamaskbot]

Policies updated

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.38%. Comparing base (4519cac) to head (d13aff2).

:exclamation: Current head d13aff2 differs from pull request most recent head e87e242. Consider uploading reports for the commit e87e242 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #24360 +/- ## =========================================== + Coverage 67.36% 67.38% +0.02% =========================================== Files 1285 1285 Lines 50088 50052 -36 Branches 12996 12992 -4 =========================================== - Hits 33738 33726 -12 + Misses 16350 16326 -24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [a8e77c6]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (953 ± 653 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	150	94	22	10
		domContentLoaded	9	38	15	7	3
		load	50	3488	953	1359	653
		domInteractive	9	38	15	7	3

Bundle size diffs [🚀 Bundle size reduced!]

• background: -30 Bytes (-0.00%)
• ui: -2 Bytes (-0.00%)
• common: -41.45 KiB (-0.70%)

[legobeat]

@metamask/assets-controllers has a peerDependency on @metamask/account-controllers.

Before this change, the direct dependency version of @metamask/account-controllers satisfies the peerDependency requirement. This change will break it. Also upgrading @metamask/account-controllers from ^11.0.0 to ^14.0.0 would make them align again.

I haven't looked closer than this, but I would think that there is something behind the peerDependency bumps?

Is it actually safe, or should @metamask/account-controllers also be upgraded alongside?

[metamaskbot]

Builds ready [99c3db1]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1256 ± 636 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	224	95	38	18
		domContentLoaded	9	53	16	10	5
		load	56	2935	1256	1325	636
		domInteractive	9	53	16	10	5

Bundle size diffs [🚀 Bundle size reduced!]

• background: -30 Bytes (-0.00%)
• ui: -2 Bytes (-0.00%)
• common: -41.45 KiB (-0.70%)

[sahar-fehri]

@metamask/assets-controllers has a peerDependency on @metamask/account-controllers.

Before this change, the direct dependency version of @metamask/account-controllers satisfies the peerDependency requirement. This change will break it. Also upgrading @metamask/account-controllers from ^11.0.0 to ^14.0.0 would make them align again.

I haven't looked closer than this, but I would think that there is something behind the peerDependency bumps?

Is it actually safe, or should @metamask/account-controllers also be upgraded alongside?

Hey @legobeat! that's a good point! I think i expected to see build errors or errors in console extension/background if a peer dependency needed an upgrade, i have tested this PR locally and i do not see any errors. I see the changelog in core marked accounts-controller v14.0.0 as breaking but maybe it does not necessarily need an update?

[metamaskbot]

Builds ready [a23a64a]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1302 ± 660 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	225	105	39	19
		domContentLoaded	9	94	18	18	9
		load	50	3250	1302	1375	660
		domInteractive	9	94	18	18	9

Bundle size diffs [🚀 Bundle size reduced!]

• background: -30 Bytes (-0.00%)
• ui: -2 Bytes (-0.00%)
• common: -41.45 KiB (-0.67%)

[metamaskbot]

Builds ready [a23a64a]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1302 ± 660 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	225	105	39	19
		domContentLoaded	9	94	18	18	9
		load	50	3250	1302	1375	660
		domInteractive	9	94	18	18	9

Bundle size diffs [🚀 Bundle size reduced!]

• background: -30 Bytes (-0.00%)
• ui: -2 Bytes (-0.00%)
• common: -41.45 KiB (-0.67%)

[sahar-fehri]

@metamaskbot update-policies

[socket-security[bot]]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

[metamaskbot]

Policies updated

[mcmire]

I just checked through the changes in the peer dependencies that assets-controllers has, and most of them are type-related, so they don't have an impact here. It seems that we can address those upgrades in a separate PR.

[metamaskbot]

Builds ready [d13aff2]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1247 ± 703 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	181	94	26	13
		domContentLoaded	9	22	12	3	1
		load	58	3754	1247	1463	703
		domInteractive	9	22	12	3	1

Bundle size diffs [🚀 Bundle size reduced!]

• background: -30 Bytes (-0.00%)
• ui: -2 Bytes (-0.00%)
• common: -41.45 KiB (-0.67%)

[metamaskbot]

Builds ready [e87e242]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (687 ± 522 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	139	80	16	8
		domContentLoaded	9	18	11	2	1
		load	49	2875	687	1088	522
		domInteractive	9	18	11	2	1

Bundle size diffs [🚀 Bundle size reduced!]

• background: -30 Bytes (-0.00%)
• ui: -2 Bytes (-0.00%)
• common: -41.45 KiB (-0.67%)