MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.52k stars 4.7k forks source link

feat: Add blockaid validation support for OPBNB network. #24361

Closed jpuri closed 1 week ago

jpuri commented 2 weeks ago

Description

Add blockaid validation support for OPBNB network.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2392

Manual testing steps

  1. Switch to opBNB network
  2. Submit transaction
  3. Ensure blockaid validation is done

Screenshots/Recordings

Screenshot 2024-05-03 at 5 23 10 PM

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 2 weeks ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sleepytanya commented 1 week ago

Looks great from QA side! Dev build b19af64

Screenshot 2024-05-06 at 17 04 28
metamaskbot commented 1 week ago
Builds ready [b19af64]
Page Load Metrics (723 ± 546 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint56142892612
domContentLoaded85518147
load4528287231136546
domInteractive85518147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 13 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 87 Bytes (0.00%)
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.34%. Comparing base (f0ac9c0) to head (6ccc595). Report is 11 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #24361 +/- ## ======================================== Coverage 67.34% 67.34% ======================================== Files 1282 1282 Lines 50066 50067 +1 Branches 12986 12986 ======================================== + Hits 33716 33717 +1 Misses 16350 16350 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

metamaskbot commented 1 week ago
Builds ready [6ccc595]
Page Load Metrics (596 ± 510 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5612380136
domContentLoaded8221442
load4529645961063510
domInteractive8221442
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 13 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 87 Bytes (0.00%)