feat: Removed multichain flag for v1 release

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites

https://metamask.io

Other

11.52k stars 4.7k forks source link

feat: Removed multichain flag for v1 release #24362

Closed NidhiKJha closed 1 week ago

NidhiKJha commented 2 weeks ago

This PR is to remove all the Multichain flags from code except the send and swap flow

Manual testing steps

Run the extension without Multichain flag.
All the changes should be there

Screenshots/Recordings

Before

After

Pre-merge author checklist

[ ] I’ve followed MetaMask Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

salimtb commented 1 week ago

@NidhiKJha you have 1 broken unit test

github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sleepytanya commented 1 week ago

I'm not sure if 'Select networks for each site' in Experimental settings should be ON by default? Seems like multichain doesn't work correctly? Sorry, if I'm missing something :).

https://github.com/MetaMask/metamask-extension/assets/104780023/a7056a1c-0876-46d5-9edc-978a3ac7b49e

codecov[bot] commented 1 week ago

Files	Patch %	Lines
ui/index.js	0.00%	12 Missing :warning:
ui/components/multichain/app-header/app-header.js	0.00%	1 Missing :warning:
...i/components/multichain/global-menu/global-menu.js	0.00%	1 Missing :warning:

```diff @@ Coverage Diff @@ ## develop #24362 +/- ## =========================================== + Coverage 67.37% 67.45% +0.08% =========================================== Files 1286 1286 Lines 50114 50077 -37 Branches 13004 12985 -19 =========================================== + Hits 33761 33777 +16 + Misses 16353 16300 -53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

metamaskbot commented 1 week ago

Builds ready [3f07521]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (944 ± 636 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	183	106	28	14
		domContentLoaded	9	66	23	16	8
		load	56	3389	944	1324	636
		domInteractive	9	66	23	16	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 529 Bytes (0.01%)
common: 96 Bytes (0.00%)