MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.52k stars 4.7k forks source link

perf: disable fence linting in test builds #24363

Closed FrederikBolding closed 1 week ago

FrederikBolding commented 2 weeks ago

Description

Disables linting of files changed by the fencing transform when using the test build target. This was already disabled for the dev build target. This should speed up CI by letting us run E2E tests more quickly, while still running the fence linting as part of the regular build step.

Looks like this saves 1-2 minutes per test-build step in CI and took my yarn build:test from 362s to 238s on my machine.

Open in GitHub Codespaces

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.37%. Comparing base (f2db014) to head (f4ecb4a).

:exclamation: Current head f4ecb4a differs from pull request most recent head f4724eb. Consider uploading reports for the commit f4724eb to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #24363 +/- ## =========================================== + Coverage 67.34% 67.37% +0.03% =========================================== Files 1282 1278 -4 Lines 50065 49881 -184 Branches 12985 12944 -41 =========================================== - Hits 33716 33605 -111 + Misses 16349 16276 -73 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

metamaskbot commented 2 weeks ago
Builds ready [f4ecb4a]
Page Load Metrics (1401 ± 710 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint712061084019
domContentLoaded106419167
load58347614011479710
domInteractive106319157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)
github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot commented 1 week ago
Builds ready [f4724eb]
Page Load Metrics (411 ± 407 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint57127772110
domContentLoaded8411173
load462566411847407
domInteractive8411173
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)