MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.52k stars 4.7k forks source link

feat: Signature Redesign update settings and title description copies #24364

Closed digiwand closed 1 week ago

digiwand commented 2 weeks ago

Description

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2459 (title description / subtitle) Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2460 (settings)

Manual testing steps

Screenshots/Recordings

Before

Screenshot 2024-04-09 at 10 49 24 PM Screenshot 2024-04-10 at 9 40 07 AM

After

Title Description / Subtitle

Screenshot 2024-05-03 at 4 42 02 PM Screenshot 2024-05-03 at 4 42 13 PM

Settings

Screenshot 2024-05-03 at 4 27 58 PM Screenshot 2024-05-03 at 4 27 20 PM

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 2 weeks ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot commented 1 week ago
Builds ready [c2f5859]
Page Load Metrics (1201 ± 661 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint712121043617
domContentLoaded97119157
load57331512011376661
domInteractive97119157
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -17 Bytes (-0.00%)
  • common: -171 Bytes (-0.00%)