MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.52k stars 4.7k forks source link

revert: deprecating more networks (#23695) #24369

Closed salimtb closed 4 days ago

salimtb commented 2 weeks ago

This reverts commit 257e9f9fce04ae4581215c1f756be40ce4e39113.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 2 weeks ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot commented 1 week ago
Builds ready [af2eab9]
Page Load Metrics (341 ± 406 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6212678157
domContentLoaded95613105
load513163341845406
domInteractive95613105
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -2.04 KiB (-0.05%)
  • ui: 356 Bytes (0.01%)
  • common: 302 Bytes (0.00%)
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.29%. Comparing base (e775193) to head (50aae8e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #24369 +/- ## =========================================== - Coverage 67.36% 67.29% -0.07% =========================================== Files 1282 1282 Lines 50011 49991 -20 Branches 12983 12971 -12 =========================================== - Hits 33685 33638 -47 - Misses 16326 16353 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

metamaskbot commented 1 week ago
Builds ready [5b08f80]
Page Load Metrics (983 ± 610 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint58145852211
domContentLoaded85515115
load4733599831271610
domInteractive85515115
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -2.04 KiB (-0.05%)
  • ui: 356 Bytes (0.01%)
  • common: 302 Bytes (0.00%)
sahar-fehri commented 1 week ago

LGTM

metamaskbot commented 4 days ago
Builds ready [50aae8e]
Page Load Metrics (1226 ± 706 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60173922914
domContentLoaded9391484
load48441312261469706
domInteractive9391484
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -1.49 KiB (-0.04%)
  • ui: 356 Bytes (0.01%)
  • common: 302 Bytes (0.00%)