fix: Remove Snaps Methods from 'methodsWithConfirmation' list used to determine whether to enqueue a request

[adonesky1]

Description

Currently Snaps can call RPC requests that do not fully conform to certain expectation built into the QueuedRequestController. wallet_invokeSnap and wallet_snap may some times cause a confirmation and in some cases they may not. Currently our blanket assumption that a method either does or does not involve a confirmation is causing an issue: wallet_invokeSnap can call (as does JSON-RPC Snap on the Test-Snaps Page) another JSON-RPC method upon which it relies for completion. In the queuing system the second request gets queued behind the first (which depends on it for its own execution) leading to a lock up.

We should resolve this issue with a more elegant solution for how these chained RPC requests should be handled by queueing. But for now it's safe to simply circumvent queueing for these Snaps methods: In the cases where there is a confirmation resulting from a wallet_invokeSnap or wallet_snap call these requests will simply not be separated from a batch with another origin, which is fine.

Related issues

Fixes: See this Slack thread

Manual testing steps

1. Go to https://metamask.github.io/snaps/test-snaps/2.6.1/
2. Connect to BIP-32 Snap
3. Connect to JSON-RPC Snap
4. Click Invoke Snap on JSON-RPC Snap
5. You should see a hex value appear below the Invoke Snap button

Screenshots/Recordings

Before

After

Pre-merge author checklist

• [ ] I’ve followed MetaMask Coding Standards.
• [ ] I've completed the PR template to the best of my ability
• [ ] I’ve included tests if applicable
• [ ] I’ve documented my code using JSDoc format if applicable
• [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [c3d6658]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (537 ± 462 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	57	132	76	23	11
		domContentLoaded	8	57	14	13	6
		load	45	2486	537	962	462
		domInteractive	8	57	14	13	6

Bundle size diffs [🚀 Bundle size reduced!]

• background: -34 Bytes (-0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)