fix: Ensure smart transaction modal is shown for users upgrading from previous versions

[danjm]

Description

This fixes a bug I found while testing v11.15.1. The bug is that currently only new users will see the "Enable Smart Transactions" modal. People who already have metamask installed and then update to v11.15.1 will not see the "Enable Smart Transactions" modal. This means that existing users won't be notified that they can turn this functionality on.

The reason is that getIsSmartTransactionsOptInModalAvailable only returns true if the result of getSmartTransactionsOptInStatus(state) is null. That depends on the smartTransactionsOptInStatus property, from the preferences controller. That property is set within the preferencesController.preferences property, which is an object, within initState of the the preferences controller. initState is always over written by pre-existing state if it existis (via the ...opts.initState, line). If a user is updating to v11.15.1 from a previous version, preferencesController.preferences from the previous version will overwrite the default preferencesController.preferences, and so smartTransactionsOptInStatus will be undefined (and not null).

The simple fix applied here is for getSmartTransactionsOptInStatus to return null if smartTransactionsOptInStatus is undefined.

Manual testing steps

1. Locally build and install v11.14.5 and onboard
2. Build this branch and update the existing local build to the build generated by this branch
3. open metamask and you should see the "Enable Smart Transactions" modal

Follow the above 3 steps on develop or on Version-v11.15.1, and there will be no modal shown on step three.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• [ ] I’ve followed MetaMask Coding Standards.
• [ ] I've completed the PR template to the best of my ability
• [ ] I’ve included tests if applicable
• [ ] I’ve documented my code using JSDoc format if applicable
• [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [54fa4e1]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (564 ± 488 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	57	138	81	22	11
		domContentLoaded	8	46	15	12	6
		load	45	3017	564	1017	488
		domInteractive	8	46	15	12	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 7 Bytes (0.00%)

[metamaskbot]

Missing release label release-11.15.2 on PR. Adding release label release-11.15.2 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.15.2.