fix: DAPP initiated swaps in MetaMask

[jpuri]

Description

Swaps initiated by DAPPS are throwing error in MetaMask.

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/24336

Manual testing steps

1. Go to Uniswap / Pancakeswap etc.
2. Start swap transaction
3. Proceed to MetaMask confirmation screen
4. Ensure no error is there

Screenshots/Recordings

Pre-merge author checklist

• [X] I’ve followed MetaMask Coding Standards.
• [X] I've completed the PR template to the best of my ability
• [X] I’ve included tests if applicable
• [ ] I’ve documented my code using JSDoc format if applicable
• [X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sleepytanya]

Dev build ddf99f1

Swaps initiated from dapps can be successfully submitted:

https://github.com/MetaMask/metamask-extension/assets/104780023/0590101a-acd3-49d7-98f7-319d88746116

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.35%. Comparing base (ff4dcfe) to head (3da3342). Report is 1 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #24382 +/- ## ======================================== Coverage 67.34% 67.35% ======================================== Files 1282 1282 Lines 50068 50070 +2 Branches 12986 12988 +2 ======================================== + Hits 33718 33720 +2 Misses 16350 16350 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [ddf99f1]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1109 ± 617 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	59	164	91	28	14
		domContentLoaded	9	31	14	5	3
		load	47	3065	1109	1285	617
		domInteractive	9	31	14	5	3

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 29 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [3da3342]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1914 ± 905 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	244	126	60	29
		domContentLoaded	8	61	23	15	7
		load	48	4581	1914	1885	905
		domInteractive	8	61	23	15	7

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 29 Bytes (0.00%)
• common: 0 Bytes (0.00%)