search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.52k stars 4.7k forks source link

[Bug]: Confirmations Redesign - Reject All does not display a confirmation popup #24384

Open seaona opened 1 week ago

seaona commented 1 week ago

Describe the bug

Whenever I am rejecting Signatures in batch, I don't see any confirmation popup as I used to see before.

Expected behavior

Show a confirmations popup before rejecting all

Screenshots/Recordings

Confirmation Redesign - no popup after clicking Reject All

Screenshot from 2024-05-06 09-58-36

Old design - popup

Screenshot from 2024-05-06 09-59-12

Steps to reproduce

  1. Trigger multiple signatures
  2. Click Reject All -- see all signatures are rejected right after

Error messages or log output

No response

Version

develop (re-design build)

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

nickpismenkov commented 1 week ago

@seaona Could you assign this bug on me? And I've a question. Do I have to ask to assign bug/feature on me before I start working on it? Or I can create PR even if the problem wasn't assigned to me?