Closed jpuri closed 1 week ago
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
@jpuri Works great! When users manually edit the gas fee for a transaction, this edited amount remains unchanged when there are updates to gas fee calculations (dev build (d2fe3c0)):
https://github.com/MetaMask/metamask-extension/assets/104780023/882d9dab-a742-434f-a852-77a31726428e
The same error is present on develop
, unrelated to current PR.
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 60 | 165 | 87 | 25 | 12 |
domContentLoaded | 9 | 29 | 13 | 5 | 2 | ||
load | 48 | 3364 | 806 | 1283 | 616 | ||
domInteractive | 9 | 29 | 13 | 5 | 2 |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.35%. Comparing base (
d27a233
) to head (d2fe3c0
). Report is 22 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Fix for user unable to manually edit gas fee in advance gas fee editing modal.
Related issues
Fixes: https://github.com/MetaMask/metamask-extension/issues/24260
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist