MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.52k stars 4.7k forks source link

feat: Add animation on the Smart Transaction status page #24389

Closed dan437 closed 1 week ago

dan437 commented 1 week ago

Description

Add animation on the Smart Transaction status page. We reused the animation from Smart Swaps.

Related issues

Fixes:

Manual testing steps

  1. Turn on Smart Transactions in Advanced Settings
  2. Use the Sepolia test network
  3. Submit a Send transaction
  4. You will see the animation on the Smart Transaction status page

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.34%. Comparing base (d27a233) to head (1e16638). Report is 15 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #24389 +/- ## =========================================== - Coverage 67.37% 67.34% -0.03% =========================================== Files 1278 1282 +4 Lines 49881 50065 +184 Branches 12944 12986 +42 =========================================== + Hits 33605 33716 +111 - Misses 16276 16349 +73 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

metamaskbot commented 1 week ago
Builds ready [1e16638]
Page Load Metrics (185 ± 252 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5611278199
domContentLoaded86515157
load452471185525252
domInteractive86515157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 358 Bytes (0.01%)
  • common: 0 Bytes (0.00%)
metamaskbot commented 1 week ago

Missing release label release-11.15.3 on PR. Adding release label release-11.15.3 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.15.3.