cherrypick: fix: Move "SettingsUpdated" event into v11.15.3 - Githubissues

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites

https://metamask.io

Other

11.52k stars 4.7k forks source link

cherrypick: fix: Move "SettingsUpdated" event into v11.15.3 #24396

Closed dbrans closed 1 week ago

dbrans commented 1 week ago

Cherry-pick f77eac57f9da62618c69fcf6f9cb86cbcbd0ada2 (#24394) into v11.15.3

github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot commented 1 week ago

Builds ready [d608adf]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1748 ± 656 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	77	192	126	32	15
		domContentLoaded	10	107	28	21	10
		load	64	3748	1748	1366	656
		domInteractive	10	107	28	21	10

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.54%. Comparing base (c9acdd3) to head (d608adf).

Files	Patch %	Lines
ui/store/actions.ts	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## Version-v11.15.3 #24396 +/- ## ==================================================== - Coverage 67.54% 67.54% -0.00% ==================================================== Files 1247 1247 Lines 48945 48946 +1 Branches 12788 12788 ==================================================== Hits 33059 33059 - Misses 15886 15887 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

metamaskbot commented 1 week ago

No release label on PR. Adding release label release-11.15.3 on PR, as PR was cherry-picked in branch 11.15.3.