fix: reset to native asset on account change

bergeron commented 1 week ago

Description

Fixes an issue when you changed accounts while sending an NFT. It would keep the NFT asset, even though the new account doesn't own it. Reset to the native asset instead.

Manual testing steps

Prepare a transaction to send an NFT
Before clicking Next, change accounts
It should reset to ETH/native token.

Screenshots/Recordings

Before

https://github.com/MetaMask/metamask-extension/assets/3500406/7628c507-a694-4bf9-8d1b-e828f7a8cdc7

After

https://github.com/MetaMask/metamask-extension/assets/3500406/1ac60586-cf97-47bc-9f4e-1e518b8a053b

Pre-merge author checklist

[ ] I’ve followed MetaMask Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sahar-fehri commented 1 week ago

Thnx for the fix! 🙏

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.38%. Comparing base (291a642) to head (0195d92). Report is 3 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #24398 +/- ## =========================================== + Coverage 67.37% 67.38% +0.01% =========================================== Files 1284 1284 Lines 50025 50020 -5 Branches 12987 12985 -2 =========================================== + Hits 33701 33705 +4 + Misses 16324 16315 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MetaMask / metamask-extension