MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.52k stars 4.7k forks source link

chore(test): skip vault-decryption e2e test if extension directory not available #24399

Closed legobeat closed 3 days ago

legobeat commented 1 week ago

Description

The vault decryptor test is documented as failing in an e2e setting (see comment for getExtensionStorageFilePath) due to the extension data directory not being available on the file system.

This skips the remainder of the test (which would otherwise throw an error) if the expected directory does not exist.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.48%. Comparing base (e3207d4) to head (8b417d6).

:exclamation: Current head 8b417d6 differs from pull request most recent head 6677820. Consider uploading reports for the commit 6677820 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #24399 +/- ## =========================================== - Coverage 67.48% 67.48% -0.00% =========================================== Files 1288 1288 Lines 50153 50153 Branches 13023 13023 =========================================== - Hits 33842 33841 -1 - Misses 16311 16312 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.