Open dan437 opened 2 weeks ago
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 70 | 168 | 91 | 23 | 11 |
domContentLoaded | 9 | 24 | 12 | 4 | 2 | ||
load | 56 | 3184 | 1161 | 1348 | 647 | ||
domInteractive | 9 | 24 | 12 | 4 | 2 |
Description
Update filtering of STX for the Activity list. There was a rare edge case when we showed a duplicated transaction in the Activity list when the transaction status was "unknown" due to reverting on chain. Now backend returns "reverted" for such transactions instead of "unknown", but just in case we have updated client-side code to only show "unknown" non-swaps transactions once in the Activity list.
Related issues
Fixes:
Manual testing steps
smartTransactionsListSelector
function you can artificially add a new smart transaction with the status "unknown". It should not show up in the Activity list.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist